Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi cell database/mq adoption #746

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

bogdando
Copy link
Contributor

@bogdando bogdando commented Nov 25, 2024

  1. Fix OSPDo specifics for single vs multi cellls

Declare RUN_OVERRIDES before it is used.
Use env vars instead of docs generation conditions to reuse the same
code in tests:

  • Add MARIADB_RUN_OVERRIDES to cover all overrides and client annotations
  • Add missing definitions for rhoso/ospd namespace specific vars
  • Use env TRIPLEO_PASSWORDS for all cases as OSPDo still deploys
    tripleo
  • Define and use NAMESPACE (default openstack) instead of
    RHOSO18_NAMESPACE or OSPDO_NAMESPACE. Remove unused rhoso18 ns value
    (only in these guide).
  1. Refactor comments in commands into asciidocs native

Illustrate how commands in scripts could have comments
that become (almost as is) native ascii docs foot-notes.

When copying code into docs, the minimal adjustments will
be needed, like adding '$' prefix (or '>' for multiline commands).

Provide a static multi-cell config for databases and messaging
for adoption guide and tests, which comprises a 3 cells.

  1. Keep renaming 'default' cell consistent for single and multi cells:

Default becomes cellX (or it can be imported as is, for a multi-cell
case only)
cell1 becomes mapped to openstack-cell1 osdp node set
cell2 becomes mapped to openstack-cell2 osdp node set, etc.
cellX (X=3 here) becomes mapped to openstack-cell3. Alternatively,
default cell retains its name for the openstack-default osdpns
mapping
Evaluate podified MariaDB passwords for cells from osp-secret
to align the tests with documented commands. Remove no longer
needed podified DB password variable.

  1. Make ansible and shell variables compute cells aware.

  2. Rework vars and secrets YAML values for the source and edpm
    nodes to not confuse its different naming schemes for cells
    in OSP/TripleO and RHOSO.

  3. Remove cached fact for pulled OSP configuration as it can no longer
    be generated in a multi-cell setup, where related shell variables
    become bash arrays.

  4. Simplify ENV headers management by collecting in a single place.

  5. Adjust storage/storageRequests values to make it better fitting
    a multi-cell test scenarios. Also provide values in docs and
    add a comment to adjust them as needed.

  6. Remove source_db_root_password as it is directly evaluated from
    tripleo passwords into an env var.

  7. Run mysql commands in individual pods.
    Finished pods take time to terminate, avoid errors where
    consequent mysql commands failing because the old and new pod use the
    same name.

  8. Rename nodesets to openstack-cell1, which is needed for adoption of
    remaining multi-cell aware services in a follow up.

  9. Make edpm_nodes input multi-cell aware.

Assume a single cell1 yet.

Remove edpm_computes and computes env var
from tests as it is not multi-cell aware, and should be no longer
needed. The docs still use that env var, it will be removed in
multi-cell adoption follow up, where we also cover EDPM multi-cell
adoption.

This is required as rhe rdo-jobs dependency introduces that
change for edpm_nodes and provides a common base for this and future
multi-cell follow ups.

  1. Unify org_namespace defaults and reference by env var

Closes: #184
Depends-On: https://review.rdoproject.org/r/c/rdo-jobs/+/53192

Jira: #OSPRH-6548

@bogdando bogdando requested a review from jistr November 25, 2024 12:48
@bogdando bogdando force-pushed the multi_cell_database branch from 3323bbf to a1207eb Compare November 25, 2024 12:49
@bogdando bogdando changed the title Multi cell database Multi cell database/mq adoption Nov 25, 2024
@bogdando
Copy link
Contributor Author

@bogdando bogdando mentioned this pull request Nov 25, 2024
@bogdando bogdando added the check-before-merge/depends-on Don't forget to check depends-on before merging label Nov 25, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ff2fa0079d2d4d0f9d107db215021a87

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph FAILURE in 1h 34m 52s
adoption-standalone-to-crc-no-ceph FAILURE in 1h 40m 01s
✔️ adoption-docs-preview SUCCESS in 1m 17s

@bogdando bogdando force-pushed the multi_cell_database branch from 0ba8ce7 to cd5b8f9 Compare November 26, 2024 12:54
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2bf5c26d9ce042488b038c87505a0f82

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph FAILURE in 1h 38m 37s
adoption-standalone-to-crc-no-ceph FAILURE in 1h 44m 16s
✔️ adoption-docs-preview SUCCESS in 1m 31s

@bogdando bogdando force-pushed the multi_cell_database branch 3 times, most recently from c392e11 to 006e247 Compare November 27, 2024 13:21
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ef997d9bd22a422fa0a81831c10ce76f

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph POST_FAILURE in 1h 40m 25s
adoption-standalone-to-crc-no-ceph RETRY_LIMIT in 10m 21s
✔️ adoption-docs-preview SUCCESS in 1m 21s

@bogdando bogdando force-pushed the multi_cell_database branch from 006e247 to 55aec9f Compare November 29, 2024 15:36
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/221b8eaa480445db948ba454fc1dc6d9

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph FAILURE in 1h 51m 13s
adoption-standalone-to-crc-no-ceph FAILURE in 53m 45s
adoption-docs-preview FAILURE in 1m 15s

@bogdando
Copy link
Contributor Author

bogdando commented Dec 2, 2024

recheck

@bogdando bogdando force-pushed the multi_cell_database branch from 55aec9f to ee3defd Compare December 2, 2024 12:27
Copy link

This change depends on a change that failed to merge.

Change https://review.rdoproject.org/r/c/rdo-jobs/+/53192 is needed.

@bogdando bogdando force-pushed the multi_cell_database branch from ee3defd to 03ce37c Compare December 4, 2024 13:04
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/28720608befb44c49d0f76f95466684b

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph RETRY_LIMIT in 48m 27s
adoption-standalone-to-crc-no-ceph RETRY_LIMIT in 48m 06s
adoption-docs-preview FAILURE in 1m 15s

@bogdando bogdando force-pushed the multi_cell_database branch 3 times, most recently from 505e4e8 to 8d81b48 Compare December 6, 2024 13:59
MARIADB_IMAGE=registry.redhat.io/rhosp-dev-preview/openstack-mariadb-rhel9:18.0
endif::[]
SOURCE_MARIADB_IP=172.17.0.2
$ PASSWORD_FILE="$HOME/overcloud-passwords.yaml"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdando bogdando force-pushed the multi_cell_database branch from 8d81b48 to cdff544 Compare December 6, 2024 14:20
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/513df93417f943f8bc8b6d3849192150

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph FAILURE in 1h 42m 09s
adoption-standalone-to-crc-no-ceph FAILURE in 1h 44m 20s
✔️ adoption-docs-preview SUCCESS in 1m 28s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/95742f210b3246b5b365a50690736dd1

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph FAILURE in 2h 53m 06s
adoption-standalone-to-crc-no-ceph FAILURE in 2h 11m 41s
✔️ adoption-docs-preview SUCCESS in 1m 26s

@bogdando bogdando force-pushed the multi_cell_database branch from c3e2073 to 12be61e Compare January 7, 2025 12:11
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9341eefb56e64f019fdb05a431eb7bc1

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph FAILURE in 3h 34m 01s
adoption-standalone-to-crc-no-ceph FAILURE in 2h 19m 10s
✔️ adoption-docs-preview SUCCESS in 1m 20s

@bogdando bogdando force-pushed the multi_cell_database branch from 12be61e to cde2221 Compare January 9, 2025 11:41
Copy link

This change depends on a change that failed to merge.

Change https://review.rdoproject.org/r/c/rdo-jobs/+/53192 is needed.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/448f64218a864e30bc1e45f7153c8f04

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph FAILURE in 3h 28m 25s
adoption-standalone-to-crc-no-ceph RETRY_LIMIT in 48m 47s
✔️ adoption-docs-preview SUCCESS in 1m 59s

bogdando and others added 9 commits January 13, 2025 13:25
Provide a static multi-cell config for databases and messaging
for adoption guide and tests, which comprises a 3 cells.

Keep renaming 'default' cell consistent for single and multi cells:

Default becomes cellX (or it can be imported as is, for a multi-cell
case only)
cell1 becomes mapped to openstack-cell1 osdp node set
cell2 becomes mapped to openstack-cell2 osdp node set, etc.
cellX (X=3 here) becomes mapped to openstack-cell3. Alternatively,
default cell retains its name for the openstack-default osdpns
mapping
Evaluate podified MariaDB passwords for cells from osp-secret
to align the tests with documented commands. Remove no longer
needed podified DB password variable.

Make ansible and shell variables compute cells aware.

Rework vars and secrets YAML values for the source and edpm
nodes to not confuse its different naming schemes for cells
in OSP/TripleO and RHOSO.

Remove cached fact for pulled OSP configuration as it can no longer
be generated in a multi-cell setup, where related shell variables
become bash arrays.

Simplify ENV headers management by collecting in a single place.

Adjust storage/storageRequests values to make it better fitting
a multi-cell test scenarios. Also provide values in docs and
add a comment to adjust them as needed.

Remove source_db_root_password as it is directly evaluated from
tripleo passwords into an env var.

Run mysql commands in individual pods.
Finished pods take time to terminate, avoid errors where
consequent mysql commands failing because the old and new pod use the
same name.

Rename nodesets to openstack-cell1, which is needed for adoption of
remaining multi-cell aware services in a follow up.

Signed-off-by: Bohdan Dobrelia <[email protected]>

Fix

Signed-off-by: Bohdan Dobrelia <[email protected]>
Declare RUN_OVERRIDES before it is used.

Use env vars instead of docs generation conditions to reuse the same
code in tests:
* Add MARIADB_RUN_OVERRIDES to cover all overrides and client annotations
* Add missing definitions for rhoso/ospd namespace specific vars
* Use env TRIPLEO_PASSWORDS for all cases as OSPDo still deploys
  tripleo
* Define and use NAMESPACE (default openstack) instead of
  RHOSO18_NAMESPACE or OSPDO_NAMESPACE. Remove unused rhoso18 ns value
  (only in these guide).

Signed-off-by: Bohdan Dobrelia <[email protected]>
Illustrate how commands in scripts could have comments
that become (almost as is) native ascii docs foot-notes.

When copying code into docs, the minimal adjustments will
be needed, like adding '$' prefix (or '>' for multiline commands).

Signed-off-by: Bohdan Dobrelia <[email protected]>
Those will be added back in a follow up, which completes
the guide and tests for extra cell2 and cell3.

Signed-off-by: Bohdan Dobrelia <[email protected]>
Assume a single cell1 yet.

Remove edpm_computes and computes env var
from tests as it is not multi-cell aware, and should be no longer
needed. The docs still use that env var, it will be removed in
multi-cell adoption follow up, where we also cover EDPM multi-cell
adoption.

This is required as rhe rdo-jobs dependency introduces that
change for edpm_nodes and provides a common base for this and future
multi-cell follow ups.

Signed-off-by: Bohdan Dobrelia <[email protected]>
Signed-off-by: Bohdan Dobrelia <[email protected]>
Use 'mysql_upgrade --skip-version-check' when truing to fix
mysqlcheck failure.

Signed-off-by: Bohdan Dobrelia <[email protected]>
@bogdando bogdando force-pushed the multi_cell_database branch from 8c9f19a to 5fad9f3 Compare January 13, 2025 12:25
Copy link

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign holser for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

This change depends on a change that failed to merge.

Change https://review.rdoproject.org/r/c/rdo-jobs/+/53192 is needed.

@bogdando
Copy link
Contributor Author

bogdando commented Jan 14, 2025

testproject and tempest has passed for the 1st time https://review.rdoproject.org/r/c/testproject/+/55584

@jistr I retriggered testproject to include remaining jobs also

@bogdando
Copy link
Contributor Author

@klgill please approve these docs changes made as you suggested, then we can address other changes in follow up.
The testing of this one is mostly finished

@bogdando
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5520cb8282f54f72890da27cfb8bd248

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 03m 36s
adoption-standalone-to-crc-no-ceph FAILURE in 2h 20m 25s
✔️ adoption-docs-preview SUCCESS in 1m 15s

@klgill
Copy link
Contributor

klgill commented Jan 14, 2025

@klgill please approve these docs changes made as you suggested, then we can address other changes in follow up. The testing of this one is mostly finished

@bogdando I think I can start looking at this PR either later today or tomorrow, if that's okay.

@bogdando
Copy link
Contributor Author

recheck

https://review.rdoproject.org/r/c/testproject/+/55584 \o/ all green! please merge all in the dep chain

@bogdando bogdando dismissed klgill’s stale review January 17, 2025 11:02

let's please re-iterate in follow up, the technical part of this is done, including testing

Copy link

This change depends on a change that failed to merge.

Change https://review.rdoproject.org/r/c/rdo-jobs/+/53192 is needed.

@bogdando
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8817c2d033f3422ab613c473a0b984dd

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 2h 59m 39s
adoption-standalone-to-crc-no-ceph POST_FAILURE in 2h 12m 29s
✔️ adoption-docs-preview SUCCESS in 1m 16s

Copy link
Contributor

@klgill klgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdando I added some comments.
Without the doc build, it's difficult for me to tell how these changes affect the formatting of the doc. When this PR is eventually merged, I will likely need to check the formatting and open a new doc PR.

@@ -396,11 +375,22 @@ endif::[]
+
<1> Select an existing storage class in your {OpenShiftShort} cluster.

This example provides the required infrastructure database and messaging services for 1 Compute cell
named `cell1`. Adjust the names, counts, IP addresses, and numbers, such as `replicas`, `storage`, or `storageRequest`, as needed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
named `cell1`. Adjust the names, counts, IP addresses, and numbers, such as `replicas`, `storage`, or `storageRequest`, as needed.
named `cell1`. Adjust the names, counts, IP addresses, and numbers, such as for `replicas`, `storage`, or `storageRequest`, as needed.

Comment on lines 393 to +394
----
Later on in this guide, the given cells names are referred to by using the environment variable `RENAMED_CELLS`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
----
Later on in this guide, the given cells names are referred to by using the environment variable `RENAMED_CELLS`.
----
+
The given cells names are later referred to by using the environment variable `RENAMED_CELLS`.

Comment on lines +88 to +93
<1> `CELLS` and `RENAMED_CELLS` represent changes that are going to be made
after importing databases: the `default` cell takes a new name from `DEFAULT_CELL_NAME`.
In a multi-cell adoption scenario, it might retain its original 'default' name as well.
<2> The `CHARACTER_SET` variable and collation should match the source database. If they do not match, then break foreign key relationships break for any tables that are created in the future as part of database sync.
<3> Complete `SOURCE_MARIADB_IP[*]= ...` data for each cell defined in `CELLS`. Provide records for the cell names and VIP addresses of MariaDB Galera clusters.
<4> For each cell defined in `CELLS`, complete `SOURCE_GALERA_MEMBERS_CELL<X>` with the names of MariaDB Galera cluster members and its IP address. Replace `["standalone.localdomain"]="172.17.0.100"` to real hosts data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<1> `CELLS` and `RENAMED_CELLS` represent changes that are going to be made
after importing databases: the `default` cell takes a new name from `DEFAULT_CELL_NAME`.
In a multi-cell adoption scenario, it might retain its original 'default' name as well.
<2> The `CHARACTER_SET` variable and collation should match the source database. If they do not match, then break foreign key relationships break for any tables that are created in the future as part of database sync.
<3> Complete `SOURCE_MARIADB_IP[*]= ...` data for each cell defined in `CELLS`. Provide records for the cell names and VIP addresses of MariaDB Galera clusters.
<4> For each cell defined in `CELLS`, complete `SOURCE_GALERA_MEMBERS_CELL<X>` with the names of MariaDB Galera cluster members and its IP address. Replace `["standalone.localdomain"]="172.17.0.100"` to real hosts data.
<1> `CELLS` and `RENAMED_CELLS` represent changes that are going to be made after you import the databases. The `default` cell takes a new name from `DEFAULT_CELL_NAME`.
In a multi-cell adoption scenario, `default` cell might retain its original 'default' name as well.
<2> The `CHARACTER_SET` variable and collation should match the source database. If they do not match, then foreign key relationships break for any tables that are created in the future as part of database sync.
<3> Add data in `SOURCE_MARIADB_IP[*]= ...` for each cell that is defined in `CELLS`. Provide records for the cell names and VIP addresses of MariaDB Galera clusters.
<4> For each cell defined in `CELLS`, in `SOURCE_GALERA_MEMBERS_CELL<X>`, add the names of the MariaDB Galera cluster members and its IP address. Replace `["standalone.localdomain"]="172.17.0.100"` with the real hosts data.

<4> For each cell defined in `CELLS`, complete `SOURCE_GALERA_MEMBERS_CELL<X>` with the names of MariaDB Galera cluster members and its IP address. Replace `["standalone.localdomain"]="172.17.0.100"` to real hosts data.

[NOTE]
A standalone {OpenStackPreviousInstaller} environment only creates a 'default' cell, which should be the only `CELLS` value for such a case. The `DEFAULT_CELL_NAME` value should be `cell1`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A standalone {OpenStackPreviousInstaller} environment only creates a 'default' cell, which should be the only `CELLS` value for such a case. The `DEFAULT_CELL_NAME` value should be `cell1`.
A standalone {OpenStackPreviousInstaller} environment only creates a 'default' cell, which should be the only `CELLS` value in this case. The `DEFAULT_CELL_NAME` value should be `cell1`.

Comment on lines +99 to +102
The `super` is not a cell, but the top-scope Nova API "upcall" database instance. A super conductor connects to that database. In this guide, the upcall and cells databases are going to use the same password that is
defined in `osp-secret`. Old passwords are only needed to prepare the data exports.

To get the values for `SOURCE_MARIADB_IP`, query the puppet-generated configurations in a Controller and CellController nodes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `super` is not a cell, but the top-scope Nova API "upcall" database instance. A super conductor connects to that database. In this guide, the upcall and cells databases are going to use the same password that is
defined in `osp-secret`. Old passwords are only needed to prepare the data exports.
To get the values for `SOURCE_MARIADB_IP`, query the puppet-generated configurations in a Controller and CellController nodes:
The `super` is the top-scope Nova API upcall database instance. A super conductor connects to that database. In subsequent examples, the upcall and cells databases use the same password that is defined in `osp-secret`. Old passwords are only needed to prepare the data exports.
To get the values for `SOURCE_MARIADB_IP`, query the puppet-generated configurations in the Controller and CellController nodes:

+
[NOTE]
The `nova`, `nova_api`, and `nova_cell0` databases are included in the same database host.
The `nova`, `nova_api`, and `nova_cell0` databases are inlcuded in the same database host for the main overcloud Heat stack.
ifeval::["{OpenStackPreviousInstaller}" != "director_operator"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ifeval::["{OpenStackPreviousInstaller}" != "director_operator"]
ifeval::["{build_variant}" == "ospdo"]

+
[NOTE]
====
This configuration is required later, during the data plane adoption post-checks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "this configuration" refer to the configuration for the neutron-sriov-nic-agent agents?

----
+
** Replace `["standalone.localdomain"]="192.168.122.100"` with the name and IP address of the Compute node.
<1> Complete `CONTROLLER<X>_SSH` settings with SSH connection details for all Controllers, including cell Controllers, of the source {OpenStackPreviousInstaller} cloud.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<1> Complete `CONTROLLER<X>_SSH` settings with SSH connection details for all Controllers, including cell Controllers, of the source {OpenStackPreviousInstaller} cloud.
<1> In the `CONTROLLER<X>_SSH` settings, provide SSH connection details for all Controller nodes, including cell Controller nodes, of the source {OpenStackPreviousInstaller} cloud.

CONTROLLER3_SSH="ssh -i *<path to SSH key>* root@*<controller-3 IP>*"
endif::[]
----
* Specify the IP addresses of all Controllers, for example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Specify the IP addresses of all Controllers, for example:
* Specify the IP addresses of all Controller nodes, for example:

----
ifeval::["{build}" == "downstream"]
<1> Replace `<path_to_SSH_key>` with the path to your SSH key.
<2> Replace `<controller-<X> IP>` with IP addresses of all Controllers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<2> Replace `<controller-<X> IP>` with IP addresses of all Controllers.
<2> Replace `<controller-<X> IP>` with IP addresses of all Controller nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check-before-merge/depends-on Don't forget to check depends-on before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nova multi-cell adoption requires different renaming technics for cells databases during importing it
5 participants